Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taps): Check replication method instead of key to determine if a SQL stream is sorted #2418

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix(taps): Check replication method instead of key to determine if a SQL stream is sorted #2418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b702fe8
fix(taps): Check replication method instead of key to determine if a …
edgarrmondragon Nov 30, 2023
88e9391
Merge branch 'main' into 2078/edgarrmondragon/fix/check-replication-m…
edgarrmondragon Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions singer_sdk/streams/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import singer_sdk.helpers._catalog as catalog
from singer_sdk._singerlib import CatalogEntry, MetadataMapping
from singer_sdk.connectors import SQLConnector
from singer_sdk.streams.core import Stream
from singer_sdk.streams.core import REPLICATION_INCREMENTAL, Stream

if t.TYPE_CHECKING:
from singer_sdk.helpers.types import Context
Expand Down Expand Up @@ -227,7 +227,7 @@ def is_sorted(self) -> bool:
Returns:
`True` if stream is sorted. Defaults to `False`.
"""
return self.replication_key is not None
return self.replication_method == REPLICATION_INCREMENTAL


__all__ = ["SQLConnector", "SQLStream"]
Loading