Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check if RK is sortable before comparing #737

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix: Check if RK is sortable before comparing #737

merged 3 commits into from
Jun 21, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

Closes #736

@edgarrmondragon edgarrmondragon self-assigned this Jun 17, 2022
@edgarrmondragon edgarrmondragon marked this pull request as ready for review June 17, 2022 22:20
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #737 (ba9f220) into main (df2790b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          34       34           
  Lines        3386     3386           
=======================================
  Hits         2887     2887           
  Misses        499      499
Impacted Files Coverage Δ
singer_sdk/helpers/_state.py 77.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2790b...ba9f220. Read the comment docs.

aaronsteers
aaronsteers approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon - Looks great. Thanks for tackling!

Feel free to merge when ready.

@edgarrmondragon edgarrmondragon merged commit 3cdb614 into main Jun 21, 2022
@edgarrmondragon edgarrmondragon deleted the 736-check-if-rk-is-sortable-before-comparing branch June 21, 2022 04:03
edgarrmondragon added a commit that referenced this pull request Jun 30, 2022
@edgarrmondragon
fix: Check if RK is sortable before comparing (#737)
5398730 
* fix: Check if RK is sortable before comparing

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if RK is sortable before comparing
2 participants
@edgarrmondragon @aaronsteers