fix: ensure all streams log sync costs #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 85.31% 85.32%
=======================================
Files 34 34
Lines 3399 3400 +1
=======================================
+ Hits 2900 2901 +1
Misses 499 499
Continue to review full report at Codecov.
|
edgarrmondragon
changed the title
edgarrmondragon
approved these changes
Jun 24, 2022
edgarrmondragon
pushed a commit
that referenced
this pull request
Jun 30, 2022
Ensure all streams log sync costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit ad0c448 in PR #704 which prevented child streams from logging their costs.
See my comment #704 (comment) for additional context.