Improved the exposure filter by changing the curve formula #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Caman.js's Exposure filter every day at GunMemorial.org and I have found that is does not behave as well as the exposure control in photo editing apps like Mac's Preview.app. Increasing the exposure does not increase the contrast, so blacks became grayish and the image looks washed-out. In other words, the Exposure filter behaves like a "brightness" control, not a typical exposure control.
In this patch, I changed the curve being used for the exposure filter and now if behaves much better for photographs. Rather than simply changing the "y-intercept" of the curve, it now changes the slope as well (which changes the contrast). The results look much better to me.
Please be aware that I do not have a NPM/CoffeeScript dev environment set up at the moment, so you should compile and test before merging. I tested the curve formula used in the patch by using the curve filter directly in JS, as seen in this commit:
https://github.com/starzia/GunMemorial/commit/8dfa1be02cedae29da772ee93facc7d385786f2d