Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize cache key with path #97

Closed
Iced-Sun opened this issue Apr 1, 2020 · 2 comments · Fixed by #86
Closed

Customize cache key with path #97

Iced-Sun opened this issue Apr 1, 2020 · 2 comments · Fixed by #86
Labels
good first issue Good for newcomers help wanted Extra attention is needed v1.1.0 Issues for v1.1.0 release WIP Work in progress

Comments

@Iced-Sun
Copy link

Iced-Sun commented Apr 1, 2020

The final cache path is generated by joining repo name and cache key (here & here). This prevents end users to fully control the cache destination (basically the structure is somewhat fixed: /<repo_name>/).

Wonder if the user could control it freely.

Regards.

@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 3, 2020

@sunbing81 thanks for reaching out, I don’t see any reason not to. We can add a new flag to override default behaviour. It’s a small change.

Feel free to send over a PR if you feel like it 🤗

@kakkoyun kakkoyun added good first issue Good for newcomers help wanted Extra attention is needed v1.1.0 Issues for v1.1.0 release labels Apr 3, 2020
@kakkoyun kakkoyun mentioned this issue Apr 5, 2020
11 tasks
@kakkoyun kakkoyun added the WIP Work in progress label Apr 5, 2020
@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 5, 2020

@sunbing81 as you can check in 7198420 with remote_root you can configure that variable now. It'll be on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed v1.1.0 Issues for v1.1.0 release WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants