-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor package structure #86
Conversation
db40a4e
to
e9792d2
Compare
Update for the eyes of accidental reviewer: This branch has gotten out of control. however please bear with me. It introduces a major overhaul on the structure and flow. This changes had been urged after the addition of several storage backends to the project. Roughly %70 of the work is done. It mostly misses tests, it'd be ready after necessary tests are added. All the issue will that would be fixed when this got merged is listed in the description. |
I think this PR too big to merge. I think you should split this PR to a couple of smaller PR's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, well done!
Added a few recommendations about general commit structure and changesets.
Since it's a huge PR, I think you should replan this PR and split it smaller PR's and reorganize your commits. Each commit should explicit and contain a single change.
GORELEASER_BIN=$(GOPATH)/bin/goreleaser | ||
LICHE_BIN=$(GOPATH)/bin/liche |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(GOPATH)/bin
used a couple of times already. Maybe it could be a good idea to move this to GOBIN=$(GOPATH)/bin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will address this in another PR
@aweris Thanks for the great review and feedback. After I'm done, I will separate it into more digestible chunks a thorough review. |
db840f6
to
1157fff
Compare
fe3870e
to
fa866ce
Compare
6841875
to
50dde38
Compare
I have cleaned the commit history. This is now ready to merge. |
952c087
to
729d146
Compare
729d146
to
c9f1214
Compare
c9f1214
to
294ce47
Compare
I'm gonna go ahead and merge this. I'll address if someone reviews it (unlikely :)) and find an issue. |
This PR changes the package structure to make it more maintainable. This need has risen after several backends merged.
Fixes several issues.
Improves automated tests.
Adopts stream-based IO processing.
Proposed Changes
archive
package.storage
package.Checklist
Unreleased
section of CHANGELOG.