Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

206-doublestar-mount Added glob path matching to mounts (initial) #209

Merged
merged 15 commits into from
Aug 11, 2022

Conversation

bdebyl
Copy link
Contributor

@bdebyl bdebyl commented Jul 18, 2022

Fixes #206

Proposed Changes

  • Add ability to glob/doublestar paths in mount settings (e.g. /path/**/dist)

Description

This feature adds the ability for drone-cache users to add glob/doublestar paths to their mount: plugin settings.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date.

@bdebyl bdebyl added enhancement New feature or request WIP Work in progress v1.4.0 Issues for v1.4.0 release labels Jul 18, 2022
@bdebyl bdebyl linked an issue Jul 18, 2022 that may be closed by this pull request
@bdebyl bdebyl self-assigned this Jul 18, 2022
@bdebyl bdebyl changed the title WIP 206-doublestar-mount Added glob path matching to mounts (initial) 206-doublestar-mount Added glob path matching to mounts (initial) Jul 19, 2022
@bdebyl bdebyl removed the WIP Work in progress label Jul 19, 2022
seandtaber
seandtaber previously approved these changes Jul 19, 2022
@bdebyl bdebyl requested a review from seandtaber August 10, 2022 17:19
Copy link
Member

@hikerspath hikerspath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdebyl bdebyl merged commit 3574624 into master Aug 11, 2022
@bdebyl bdebyl deleted the 206-doublestar-mount branch August 11, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.4.0 Issues for v1.4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doublestar support in mount array
3 participants