Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the bug when using Huggingface Models #1877

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

parshvadaftari
Copy link
Contributor

@parshvadaftari parshvadaftari commented Sep 17, 2024

Description

Changing the return type of the HuggingFace Embeddings from ndarray to List

Fixes #1752

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


parshvadaftari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@parshvadaftari
Copy link
Contributor Author

Weird as it runs on my Macbook. The Tests are successfull with all 3 of the python versions, 3.10, 3.11 and 3.12.
Is it due to Macbook?

@Dev-Khant
Copy link
Collaborator

Hey @parshvadaftari Can you please check the failing tests?

@parshvadaftari
Copy link
Contributor Author

@Dev-Khant I've attached the test script for the updated huggingface embeddings. And made sure that the test have passed on my locak using the make test.

@Dev-Khant
Copy link
Collaborator

Thanks for the contribution @parshvadaftari

@Dev-Khant Dev-Khant merged commit 0491854 into mem0ai:main Sep 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hugging Face Embedding Error with Bug
3 participants