Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full api-gateway naming migration #741

Open
koin612 opened this issue Sep 18, 2023 · 2 comments
Open

full api-gateway naming migration #741

koin612 opened this issue Sep 18, 2023 · 2 comments
Milestone
6.0

Comments

@koin612
Copy link
Contributor

koin612 commented Sep 18, 2023

there are still some service-proxy namings in the project.

I think we should prioritise the names in the release to not cause confusion for the end user.

~/Downloads/membrane-api-gateway-5.2.0 via ☕ v17.0.7 
❯ grep -Rnw . -e 'service-proxy' | wc -l
     284
@predic8 predic8 added this to the 6.0 milestone Sep 18, 2023
@predic8
Copy link
Member

predic8 commented Sep 18, 2023

Renaming service-proxy.sh files will break a lot. Maybe we should wait till Version 6.0.

@christiangoerdes
Copy link
Collaborator

Tried it at Branch #741-api-gateway-naming-migration and all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@predic8 @koin612 @christiangoerdes