Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcached 1.6.9 - HWCAP_CRC32 undefined - arm64 build with gcc-4.8 #743

Closed
sergey-dryabzhinsky opened this issue Nov 24, 2020 · 2 comments
Closed

memcached 1.6.9 - HWCAP_CRC32 undefined - arm64 build with gcc-4.8 #743

sergey-dryabzhinsky opened this issue Nov 24, 2020 · 2 comments
Labels
merged/fixed for next

Comments

@sergey-dryabzhinsky
Copy link

Describe the bug
memcached 1.6.9 arm64 build on Ubuntu 14.04 - produce error HWCAP_CRC32 undefined.

To Reproduce
Try to build memcached on Launchpad for Ubuntu 14.04 for arm64

System Information

  • OS/Distro: Ubuntu
  • Version of OS/distro: 14.04
  • Version of memcached: 1.6.9
  • Hardware detail: arm64

Detail (please include!)

gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -DNDEBUG -D_FORTIFY_SOURCE=2  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -O2 -mcpu=cortex-a53 -mtune=cortex-a53 -pthread -pthread -Wall -Werror -pedantic -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -c -o memcached-crc32c.o `test -f 'crc32c.c' || echo './'`crc32c.c
crc32c.c: In function 'crc32c_init':
crc32c.c:336:16: error: 'HWCAP_CRC32' undeclared (first use in this function)
     if (auxv & HWCAP_CRC32)
                ^
crc32c.c:336:16: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [memcached-crc32c.o] Error 1
@sergey-dryabzhinsky sergey-dryabzhinsky mentioned this issue Nov 24, 2020
Closed
@sergey-dryabzhinsky
Copy link
Author

Version 1.6.8 builds fine.

Seems like in old libc/gcc constant HWCAP_CRC32 not defined.
So check it.

PR: #744

@dormando
Copy link
Member

Out in 1.6.10

hgy59 added a commit to smaarn/spksrc that referenced this issue May 21, 2022
@hgy59
memcached: rework
da8abee 
- update memcached to v1.6.15
- aarch64 patch is not required (memcached/memcached#743 is not an issue)
- update phpMemcachedAdmin to include fix for 1.6.x
- fix service user
hgy59 added a commit to SynoCommunity/spksrc that referenced this issue Jun 4, 2022
@smaarn @hgy59
memcached: upgrade 1.6.9 + DSM7 support (#4522)
5ce6622 
* memcached: bump 1.4.13 -> 1.6.9
+ reworked to use standard "framework"
* Add DSM 7 support logics
* Fixed invalid no-arch switch
* Added missing CONF_DIR parameter
* Fixed setup to handle configuration file
* Improve upgrade procedure
* Cleanup unnecessary code
* Fix upgrade procedure attempt #2
* Cleanup of enforced compilation parameters
* Attemptive fix at configuration files
* Fixing backup process
* Fixed invalid WEB_DIR environment variable
* Replace the default configuration file by a file provided upon package generation
* Fixed restoration to be performed
* Prefer using tar command to perform backups
* Simplified web directory computing + fixed sc-memcecahed to be part of the http group
* Remove verbosity on tar extraction commands
* Added explicit service port informations
* Fixed resource to include service port configuration
* memcached: rework
- update memcached to v1.6.15
- aarch64 patch is not required (memcached/memcached#743 is not an issue)
- update phpMemcachedAdmin to include fix for 1.6.x
- fix service user
* memcached: rework (2)
- use custom app/config file to link with phpMemcachdAdmin
- update icon
- set owner of config file on DSM < 7
* minor cleanup
- update license
- remove autoconf as configure script is included
* activate DSM 7 webservice icon
- avoid default DSM UI icon on DSM 7
* add diyspk/memaslap to test and benchmark memcached server
- add cross/libmemcached
- enable build of memaslap
- fix build for DSM 7 (issue with newer compilers)
- add patches for correct program name and faster build
* memcachd: optimize code
- use code optimization
- fix build for OLD_PPC_ARCHS
* fix phpmemcachedadmin configuration
- update phpmemcachedadmin to store config in var folder and link as Config into web folder
- fix folder permissions for phpmemcachedadmin
- create Memcache.php on demand

* framework: enhanced for custom app/config file
- add Makefile variable DSM_UI_CONFIG for package specific app/config files

* update generic installers
- remove SYNOPKG_DSM_VERSION_MAJOR check in installers
- use GROUP variable for group in set_unix_permissions for DSM 6

Co-authored-by: hgy59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
merged/fixed for next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dormando @sergey-dryabzhinsky