Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test build on different platforms #110

Closed
wants to merge 11 commits into from

Conversation

antoniofilipovic
Copy link
Contributor

@antoniofilipovic antoniofilipovic commented Dec 14, 2021

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Unit tests
  • End-to-end tests
  • Code documentation
  • README short description
  • Documentation on memgraph/docs

######################################

Tried testing build with Docker on windows virtual environment and due to issues with windows server 2019 and windows server 2022 we are closing PR. Followig issues are here:

  1. Windows server 2019 - Currently nope, you can't install Docker Desktop in CI due to limitations of virtual environments:
  • Microsoft-Hyper-V component is not enabled on Windows Server 2019 image and needs reboot to enable this component.
  • DSv2 vm instance, they are currently using, doesn't support nested virtualization
  1. Windows Server 2022 - WSL2 has been removed from Windows Server 2022 so it's not possible to run Linux containers in WSL. See WSL 2 broken on Windows Server Preview (since change to fe_release branch) microsoft/WSL#6301 (comment)

See whole discussion here:actions/runner-images#1143

@antoniofilipovic antoniofilipovic deleted the T040-MAGE-mage-build-different-platforms branch December 15, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant