Switch from unreliable to more stable Travis variable. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRAVIS_COMMIT_RANGE seems to have many people complaining about it online, and we've had cases where it fails to check pull requests properly. Use TRAVIS_BRANCH and Git FETCH_HEAD instead, which should be more stable. See the discussion here: travis-ci/travis-ci#1719 Signed-off-by: Kristian Amlie <[email protected]>
|
I guess we'll need to roll out dependency update to all repos |
Yep, I can do that. I will attempt a new pull request with invalid signoff first, just to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRAVIS_COMMIT_RANGE seems to have many people complaining about it
online, and we've had cases where it fails to check pull requests
properly. Use TRAVIS_BRANCH and Git FETCH_HEAD instead, which should
be more stable. See the discussion here:
travis-ci/travis-ci#1719
Signed-off-by: Kristian Amlie [email protected]