Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fork tests #390

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: fork tests #390

merged 2 commits into from
Mar 5, 2024

Conversation

baroooo
Copy link
Contributor

@baroooo baroooo commented Mar 4, 2024

Description

Fixes broken fork tests after MU05
1- Included MockNativeUSDC in the test setup to fund reserve for tests
2- Added a check to prevent the test going into infinite loop for native USDC swaps

Tested

Fork tests are green on baklava

@baroooo baroooo requested review from a team, nvtaveras and RyRy79261 and removed request for a team March 4, 2024 16:31
Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  • i ran baklava fork tests on develop => broken as expected
  • i ran baklava fork tests on this branch => fixed as expected 👍

@RyRy79261
Copy link

Sorry for the delay, just shuffling my environments around

@nvtaveras nvtaveras merged commit 785181c into develop Mar 5, 2024
6 checks passed
@nvtaveras nvtaveras deleted the fix/MU05-fork-tests branch March 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants