fix: hardcoded emission supply #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: hardcoded emission supply
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
bayological
approved these changes
Mar 11, 2024
philbow61
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We forgot to update hardcoded emission supply in the emission contract after making allocations parametrised. This may cause issues with the emission calculation when the emission supply in the token contract is not equal to the hardcoded emission supply in the emission contract.
This fix removes the hardcoded emission supply, and sets it through init call from the governance factory.
Other changes
No
Tested
Fixed unit tests
Related issues