Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove look-up on integration tests in pytest.ini #16

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

TiansuYu
Copy link
Contributor

@TiansuYu TiansuYu commented Mar 15, 2022

Description

Test lookup the integration_test dir which doesnt exist yet. Disable this at the moment in pytest.ini.
The other changes credit to my black file watcher.

Update: branch test passes, that is a good sign, meaning the main CI have a high chance to pass as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the [contributing guideline doc] () (external only)
  • I have signed the [CLA] () (external only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@winfried-ripken winfried-ripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tiansu, looks good. I will look into using the black watcher

@TiansuYu TiansuYu merged commit f68856b into main Mar 16, 2022
@TiansuYu TiansuYu deleted the tiansu-remove-integration-test-lookup branch March 16, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants