Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme + classifiers in setup.py #17

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Mar 16, 2022

Description

Update setup.py to make cloudbuild green

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the [contributing guideline doc] () (external only)
  • I have signed the [CLA] () (external only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@TiansuYu TiansuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiansuYu
Copy link
Contributor

The linting problem should be solved after rebase with main. And dont forget to install pre-commit for each repo that has it.

@winfried-ripken winfried-ripken merged commit 846642d into main Mar 16, 2022
@winfried-ripken winfried-ripken deleted the winnie-update-setup branch March 16, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants