Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLA + CoC #21

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Add CLA + CoC #21

merged 4 commits into from
Mar 30, 2022

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Mar 29, 2022

Description

  • Add code of conduct in documentation
  • Add CLA and reference it with CLA bot
  • Fix pre-commit: bump black version to 22.3.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the [contributing guideline doc] () (external only)
  • I have signed the [CLA] () (external only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@TiansuYu TiansuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question: Where will be the signatures be saved? If this is saved in this repo, does that mean personal information will be collected and shared?

path-to-document: 'https://github.com/merantix-momentum/squirrel-datasets-core/blob/master/CLA.md' # e.g. a CLA or a DCO document
# branch should not be protected
branch: 'signed-cla'
allowlist: TiansuYu,AlpAribal,AlirezaSohofi,ThomasWollmann,jotterbach,mx-momentum-minionbot*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include yourself?
And is it possible to add a team inside?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing Tiansu! I excluded myself on purpose, because I wanted to test the functionality with my account.

From the documentation:
After the contributor signed a CLA, the contributor's signature with metadata will be stored in a JSON file inside the repository

I understand that the github username and a reference to the PR will be stored. This information would also be publicly available from the PR itself. In the case we want to avoid the signed CLAs being publicly available, we can store them in a separate repository (e.g. oss-infra). Only requirement would be that the cla-bot has access to this other repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find any information about including teams, but will try that. Wildcards are supported for the allowlist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the moment, collecting github account names in this repo is fine, as they are already publicly available anyway in the git history. Thx for the explanation.

@winfried-ripken
Copy link
Contributor Author

This is blocked until we figure out how the bot can get access to our repositories (probably by adding another minion account)

Copy link
Contributor

@TiansuYu TiansuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great!

@winfried-ripken winfried-ripken merged commit 5e2a3f1 into main Mar 30, 2022
@winfried-ripken winfried-ripken deleted the winnie-cla-coc branch March 30, 2022 08:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants