-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLA + CoC #21
Add CLA + CoC #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question: Where will be the signatures be saved? If this is saved in this repo, does that mean personal information will be collected and shared?
.github/workflows/cla.yml
Outdated
path-to-document: 'https://github.com/merantix-momentum/squirrel-datasets-core/blob/master/CLA.md' # e.g. a CLA or a DCO document | ||
# branch should not be protected | ||
branch: 'signed-cla' | ||
allowlist: TiansuYu,AlpAribal,AlirezaSohofi,ThomasWollmann,jotterbach,mx-momentum-minionbot* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include yourself?
And is it possible to add a team inside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing Tiansu! I excluded myself on purpose, because I wanted to test the functionality with my account.
From the documentation:
After the contributor signed a CLA, the contributor's signature with metadata will be stored in a JSON file inside the repository
I understand that the github username and a reference to the PR will be stored. This information would also be publicly available from the PR itself. In the case we want to avoid the signed CLAs being publicly available, we can store them in a separate repository (e.g. oss-infra). Only requirement would be that the cla-bot has access to this other repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not find any information about including teams, but will try that. Wildcards are supported for the allowlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the moment, collecting github account names in this repo is fine, as they are already publicly available anyway in the git history. Thx for the explanation.
This is blocked until we figure out how the bot can get access to our repositories (probably by adding another minion account) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks great!
Description
Type of change
Checklist: