Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public release #25

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Public release #25

merged 5 commits into from
Apr 5, 2022

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Apr 5, 2022 •
edited
Loading

Description

Update documentation to reference readthedocs + double-check all links
Pin squirrel V0.12.1
Update setup.py for public release

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the [contributing guideline doc] () (external only)
  • I have signed the [CLA] () (external only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

TiansuYu
TiansuYu approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@TiansuYu TiansuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiansuYu
Copy link
Contributor

TiansuYu commented Apr 5, 2022

I would pin the version to >=0.12.1

TiansuYu
TiansuYu reviewed Apr 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@winfried-ripken winfried-ripken merged commit 7c7dede into main Apr 5, 2022
@winfried-ripken winfried-ripken deleted the winnie-public-release branch April 5, 2022 11:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TiansuYu TiansuYu TiansuYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winfried-ripken @TiansuYu