Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back importlib-resources #44

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Add back importlib-resources #44

merged 2 commits into from
Jun 28, 2022

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Jun 28, 2022

Description

Fix failing cloud build

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With python 3.8, pip-tools adds importlib-resources automatically to the reqs.txt (without adding to reqs.dev.in). With python 3.9, this dependency is not added.

The reason is jsonschema, which has the dependency "importlib_resources>=1.4.0;python_version<'3.9'",. Since importlib-resources is a backport package, I assume the standard library is enough for jsonschema starting with python 3.9.

To prevent such cases, we should all be using the same environment for development. Always using the project container for development would probably be the best approach. The minimum we should do is to use the same python version as the container (which is 3.8, at least for now) in our development environment.

For this particular case, I suggest removing importlib-resources from the reqs.dev.in and freezing using python 3.8.

@winfried-ripken
Copy link
Contributor Author

Thanks Alp, for the clarification! I wasn't aware of this, I followed you suggestion to re-freeze the requirements.

Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@winfried-ripken winfried-ripken merged commit a41186b into main Jun 28, 2022
@winfried-ripken winfried-ripken deleted the winnie-requirements branch June 28, 2022 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants