Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to fem data #46

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Add links to fem data #46

merged 3 commits into from
Aug 16, 2022

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Jun 28, 2022

Description

Integrate data links to catalog for paper "Learning the Solution Operator of Boundary Value Problems using Graph Neural Networks"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@winfried-ripken winfried-ripken marked this pull request as ready for review August 16, 2022 10:26
Copy link
Contributor

@axkoenig axkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except 1 comment. if you want you could also add Merantix Momentum or the paper title in the metadata of each source, but this is not a must (maybe we can think of some policy here)

@@ -0,0 +1,116 @@
# Exemplary sources for the huggingface driver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick review! Nice idea about the metadata, will do 👍

@winfried-ripken winfried-ripken merged commit d360137 into main Aug 16, 2022
@winfried-ripken winfried-ripken deleted the winnie-gnn-bvp-data branch August 16, 2022 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants