Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to py3.9 #50

Merged
merged 6 commits into from
Aug 15, 2022
Merged

Upgrade to py3.9 #50

merged 6 commits into from
Aug 15, 2022

Conversation

AlpAribal
Copy link
Contributor

@AlpAribal AlpAribal commented Aug 15, 2022

Description

Bumps the python version in the base image to 3.9 and refreezes requirements with py3.9. All frozen requirements were updated to their latest suitable version.

I started with an empty requirements file so that the hashes were not reused. In this case, pip-compile generates hashes for all binaries/wheels of the package, which is the reason for the huge diff in reqs.txt

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@AlpAribal
Copy link
Contributor Author

The build is failing since the base image is not updated (only gets updated after merging to main) but the reqs are.

Copy link
Contributor

@winfried-ripken winfried-ripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Alp! I think the failing cloud build will be green after the base image has been rebuilt - If you agree I can trigger the main build for this branch to check

@AlpAribal
Copy link
Contributor Author

If you agree I can trigger the main build for this branch to check

I did not know it was possible, yes please, would be great!

@winfried-ripken
Copy link
Contributor

winfried-ripken commented Aug 15, 2022

I think this line in the pre-commit config is still creating a problem?

default_language_version:
  python: python3.8

Also can we change the python version in setup.py?

@AlpAribal
Copy link
Contributor Author

Also can we change the python version in setup.py?

We still want to support py3.8, so won't bump the version there.

Copy link
Contributor

@winfried-ripken winfried-ripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@AlpAribal AlpAribal merged commit 5682747 into main Aug 15, 2022
@AlpAribal AlpAribal deleted the alp-py39 branch August 15, 2022 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants