-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to py3.9 #50
Upgrade to py3.9 #50
Conversation
The build is failing since the base image is not updated (only gets updated after merging to main) but the reqs are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Alp! I think the failing cloud build will be green after the base image has been rebuilt - If you agree I can trigger the main build for this branch to check
I did not know it was possible, yes please, would be great! |
I think this line in the pre-commit config is still creating a problem?
Also can we change the python version in setup.py? |
We still want to support py3.8, so won't bump the version there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Description
Bumps the python version in the base image to 3.9 and refreezes requirements with py3.9. All frozen requirements were updated to their latest suitable version.
I started with an empty requirements file so that the hashes were not reused. In this case, pip-compile generates hashes for all binaries/wheels of the package, which is the reason for the huge diff in reqs.txt
Type of change
Checklist: