-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks for jupyter notebooks #54
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to push a notebook with outputs (in a separate branch) using this configuration. Could you make a dummy commit with outputs in the PR so that we check that the hook is working?
Currently, there is an issue with nbstripout, that prevents it from been run locally. I have created a mirror-repository implementing the changes that would fix the issue until it's solved at nbstripout's side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Nice catch! |
Description
We have our example notebooks in the sq-ds-core repo. To standardize notebook outputs, prevent private information leakage, and reduce PR diffs, we can introduce an nbstripout precommit hook.
Fixes # issue
Type of change
Checklist: