Fix Driver imports #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axkoenig
commented
Dec 15, 2022
| @@ -70,10 +79,7 @@ def squirrel_sources() -> List[Tuple[CatalogKey, Source]]: | |||
| import squirrel_datasets_core.datasets as ds | |||
|
|
|||
| for m in pkgutil.iter_modules(ds.__path__): | |||
| try: | |||
| with contextlib.suppress(AttributeError): | |||
There was a problem hiding this comment.
my IDE suggested this change, I think it's much cleaner that way. https://docs.python.org/3/library/contextlib.html
winfried-ripken
approved these changes
Dec 15, 2022
| @@ -36,6 +44,7 @@ def squirrel_drivers() -> List[Type[Driver]]: | |||
| drivers = [] | |||
| add_drivers = { | |||
There was a problem hiding this comment.
Can we also wrap this in a try/except block like below and catch any import errors? This would prevent squirrel from crashing when datasets is installed and some requirements are missing
There was a problem hiding this comment.
are you referring to line 42?
There was a problem hiding this comment.
Ah sorry, I got confused, please ignore this comment :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from squirrel_datasets_core.driver.huggingface import HuggingfaceDriverthesquirrel_datasets_core.driveris called, an since we have all the imports in there we also needed our users to install all of those dependencies, which is not good - because they might not even need them.squirrel_datasets_core.drivermodule and ask users to directly import the respective driver from the respective submoduleType of change