Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSR-22416: Show accurate subtotal for taxInclusive accounts #93

Merged
merged 2 commits into from
Sep 19, 2023
Merged

LSR-22416: Show accurate subtotal for taxInclusive accounts #93

merged 2 commits into from
Sep 19, 2023

Conversation

ls-deepak-yadav
Copy link
Contributor

@ls-deepak-yadav ls-deepak-yadav commented Sep 19, 2023 •
edited
Loading

Description

The subtotal amount for taxInclusive accounts was inaccurate. This PR fixes that.

WebPOS PR: https://github.com/merchantos/webPOS/pull/21670

Evidence

Before Fix

tax_inclusive_before_fix_show_discounts tax_inclusive_before_fix tax_excusive_before_fix_show_discounts tax_exclusive_before_fix

After Fix

tax_inclusive_after_fix tax_inclusive_after_fix_show_discounts tax_exclusive_after_fix_show_discounts tax_exclusive_after_fix

@ls-deepak-yadav ls-deepak-yadav self-assigned this Sep 19, 2023
ls-lindsay-powerharding
ls-lindsay-powerharding approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ls-lindsay-powerharding ls-lindsay-powerharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting/linting errors to be fixed before merge

@ls-deepak-yadav ls-deepak-yadav merged commit c2971fc into master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-dev-aleriola brandon-dev-aleriola brandon-dev-aleriola approved these changes

@ls-lindsay-powerharding ls-lindsay-powerharding ls-lindsay-powerharding approved these changes

@ls-conor-macpherson ls-conor-macpherson ls-conor-macpherson approved these changes

Assignees

@ls-deepak-yadav ls-deepak-yadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ls-deepak-yadav @brandon-dev-aleriola @ls-lindsay-powerharding @ls-conor-macpherson