Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSR-27518: [Receipts] - Update Print Templates Repo #95

Merged

Conversation

ls-lindsay-powerharding
Copy link
Contributor

@ls-lindsay-powerharding ls-lindsay-powerharding commented Mar 15, 2024

Update workorder and sale receipt templates to support item fees

Will add the link to the update help center article once it's available

@ls-lindsay-powerharding ls-lindsay-powerharding marked this pull request as draft March 15, 2024 13:46
@ls-lindsay-powerharding ls-lindsay-powerharding changed the title LSR-27518: update print templates for item fees feature LSR-27518: [Receipts] - Update Print Templates Repo Mar 15, 2024
Copy link
Contributor

@ls-conor-macpherson ls-conor-macpherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Lindsay! :)

@@ -520,6 +535,19 @@ img.barcode {
{% endif %}
</td>
</tr>
{% for WorkorderSaleLine in Line.SaleLine %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want these changes in other languages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Totally my mistake, good catch. I'll update the other languages

@ls-deepak-yadav
Copy link
Contributor

Will approve it soon but let's avoid merging it today. We can merge it on Moday

Copy link
Contributor

@ls-deepak-yadav ls-deepak-yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ls-lindsay-powerharding ls-lindsay-powerharding merged commit 234fe96 into master Mar 20, 2024
@ls-lindsay-powerharding ls-lindsay-powerharding deleted the LSR-27518_update-print-templates-for-item-fees branch March 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants