LSR-28559 - Translate Sale Receipt Templates to Supported Languages #98
Conversation
…webOS repo prior.
ls-jeremy-aalders
requested review from
patrickpicher-lightspeed,
ls-lindsay-powerharding and
IvanChau1023
|
This will also cover the other updates for 'subtotal' on ES print templates |
receipt/SaleReceipt.tpl
Outdated
| @@ -845,7 +901,7 @@ table.payments td.label { | |||
| {% endif %} | |||
|
|
|||
| {% if Sale.Customer %} | |||
| {% if Sale.Customer.company|strlen > 0 %} | |||
| {% if Sale.Customer.company|strlen > 0 and not options.show_customer_name_only %} | |||
There was a problem hiding this comment.
There seems to be some additional updates beyond what is required for this cycle, is that intended?
There was a problem hiding this comment.
Will we need these changes to our public files? https://github.com/merchantos/webPOS/commit/a93700b6e037ed7629d7f2e95090159318baf29c
There was a problem hiding this comment.
Potentially, we should keep these templates the same as the source of truth, but for clarity sake let's keep this PR specific just to the changes required to show remote payment links for this cycle and we can create additional tasks to add in any other adjustments at another time
There was a problem hiding this comment.
Since our public repos are suppose to match with what's in merchantOS, would it be possible to just keep the PR as is so that way we have both bases covered now and we don't have to come back?
There was a problem hiding this comment.
I'd prefer to just keep this specific for this cycle's updates especially if a merchant/support were to ever use this PR as a reference of what to update.
There was a problem hiding this comment.
This should now be updated as per your feedback.
ls-jeremy-aalders
added
the
DO NOT MERGE YET
ls-jeremy-aalders
changed the title
This is just a reflection update to update our public facing repo with the translations that were done prior