fix: invalid host header issue on codesandbox #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves Issue merkle-open#94 (The examples no longer work in CodeSandbox environments.) We need to add the allowedhosts-flag to devServer-settings for webpack.config: devServer-config to solve "Invalid Host header Issue" on CodeSandBox: codesandbox/codesandbox-client#3392 and https://stackoverflow.com/a/43647767 and https://codesandbox.io/docs/learn/repositories/task#configuring-task-ports https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#firewall https://webpack.js.org/configuration/dev-server/#devserverallowedhosts firewall: false, // failed while testing disableHostCheck: true, // failed while testing allowedHosts: This flag finally solved it
ernscht
added
enhancement
ernscht
requested changes
Oct 19, 2023
solves Issue merkle-open#94 (The examples no longer work in CodeSandbox environments.) We need to add the allowedhosts-flag to devServer-settings for webpack.config: devServer-config to solve "Invalid Host header Issue" on CodeSandBox: codesandbox/codesandbox-client#3392 and https://stackoverflow.com/a/43647767 and https://codesandbox.io/docs/learn/repositories/task#configuring-task-ports https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#firewall https://webpack.js.org/configuration/dev-server/#devserverallowedhosts firewall: false, // failed while testing disableHostCheck: true, // failed while testing allowedHosts: This flag finally solved it
ernscht
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves Issue #94 (The examples no longer work in CodeSandbox environments.)
We need to add the allowedhosts-flag to devServer-settings for webpack.config:
devServer-config to solve "Invalid Host header Issue" on CodeSandBox:
codesandbox/codesandbox-client#3392 and
https://stackoverflow.com/a/43647767 and
https://codesandbox.io/docs/learn/repositories/task#configuring-task-ports
https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md#firewall
https://webpack.js.org/configuration/dev-server/#devserverallowedhosts
firewall: false, // failed while testing
disableHostCheck: true, // failed while testing
allowedHosts: This flag finally solved it
Purpose of this pull request?
What changes did you make?
Does this pull request introduce a breaking change?
Is there anything you'd like reviewers to focus on?