Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .d.ts extension from the TS Plugin #18

Open
janbiasi opened this issue Nov 20, 2018 · 0 comments
Open

Remove .d.ts extension from the TS Plugin #18

janbiasi opened this issue Nov 20, 2018 · 0 comments
Assignees
Labels
bug Something isn't working check ts-config ts-config-webpack-plugin

Comments

@janbiasi
Copy link
Contributor

janbiasi commented Nov 20, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

If you have a project (Nitro for example) with Babel and no TypeScript files it will include the d.ts files in the build cycle which fails because d.ts files are not compilable whether by the ts-loader nor the fork plugin. We already tested out that if we remove the .d.ts in the resolver extensions everything works as expected (also detecting typing issues in Gondel for example).

Described line is in https://github.com/namics/webpack-config-plugins/blob/master/packages/ts-config-webpack-plugin/src/TsConfigWebpackPlugin.js#L71

Expected behavior

It should not throw an error in case of d.ts imports.

Minimal reproduction of the problem with instructions

  1. Check out the latest Nitro version
  2. Install Gondel
  3. Enable TS in the config
  4. Watch the build fail (even if no TS files provided)

Environment


Plugin version: *

 
- Node version: 8  
- Platform:  Mac & Windows 

Others:

@janbiasi janbiasi self-assigned this Nov 20, 2018
@janbiasi janbiasi added the bug Something isn't working label Nov 20, 2018
This was referenced Jan 4, 2021
nemchik added a commit to nemchik/webpack-config-plugins that referenced this issue Jan 4, 2021
nemchik added a commit to nemchik/webpack-config-plugins that referenced this issue Apr 7, 2021
nemchik added a commit to nemchik/webpack-config-plugins that referenced this issue Apr 20, 2021
@ernscht ernscht added the ts-config ts-config-webpack-plugin label Apr 21, 2021
@ernscht ernscht added this to the Fixes for 2.x (webpack 4) milestone Apr 22, 2021
@ernscht ernscht mentioned this issue Sep 10, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working check ts-config ts-config-webpack-plugin
Development

No branches or pull requests

3 participants