Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange node-sass with sass package in scss config webpack plugin #133

Conversation

LOK-Soft
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] tooling / infrastructure changes
[x] Other... Please describe: Package replacement to be able to update node-version to v16

What is the current behavior?

scss config webpack plugin can not be used with node v16 due to the node-sass dependency

What is the new behavior?

scss config webpack plugin can be used with node v16

Does this PR introduce a breaking change?

[x] Yes
[ ] No

PR contains update of node version
This change is not necessarily breaking but might make problems with other used dependencies in the project.
New version will not work below node version 16

Other information

@LOK-Soft
Copy link
Author

strangely the build and test also seem to work with lower node-versions, but in the project the usage of the scss config webpack plugin failed with version 14, but only worked with 16

@ernscht
Copy link
Member

ernscht commented Oct 24, 2024

Thank you for your work, but we already have this change in develop. See: #92 and #132
I am therefore closing ths PR.

Besides:
The plugin should work with node-sass and node version 16. (node-sass has to be compiled in projects: e.g. with npm rebuild node-sass)

@ernscht ernscht closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants