Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple listeners #70

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Multiple listeners #70

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7878b8
Log clicks
bartekch Jan 31, 2023
c1f9b71
Multiple listeners fix
bartekch Jan 31, 2023
ecdac28
Update loadingbutton.js
bartekch Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 28 additions & 20 deletions inst/assets/js/loadingbutton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,20 @@ function LoadingButtons() {
}

LoadingButtons.prototype.create = function (inputId, options) {

var id = Math.random(1);
console.log("Creating button with id " + id);
var btn_value = null;
// find all loading buttons in the dom and remove any loading buttons from
// this.buttons that are no longer in the dom. By running this "garbage collection"
// each time we add a new loading button to the dom we protect against the this.loadingButtons
// object growing out of control as loading buttons are quickly added and removed from the dom
var self = this;
$(function() {
var allDOMLoadingButtons = $(document).find(".sf-loading-button");
var loadingIds = [];
for(var obj of allDOMLoadingButtons) {
loadingIds.push(obj.id);
}

// if element in this.buttons represents a loadingButton that is no longer in the DOM
// then remove it from this.buttons. Also remove remove it if the button being added already
// exists in this.buttons
self.buttons = self.buttons.filter(obj => {
return loadingIds.includes("sf-loading-button-" + obj.inputId) && (obj.inputId !== inputId);
});

self.buttons.push({inputId: inputId, options: options});
});

// Disable button & change text
$(document).on('click', "#" + inputId, function() {
click_button = function() {
// increment the button value by 1. This is consistent with how `shiny::actionButton`
// value works.

console.log("Click button " + id + " with value ", btn_value);

if (btn_value === null) {
btn_value = 1;
} else {
Expand All @@ -49,7 +34,30 @@ LoadingButtons.prototype.create = function (inputId, options) {
loading_button.attr('style', options.loadingStyle);
loading_button.removeClass(options["class"]);
loading_button.addClass(options.loadingClass);
};

$(function() {
var allDOMLoadingButtons = $(document).find(".sf-loading-button");
var loadingIds = [];
for(var obj of allDOMLoadingButtons) {
loadingIds.push(obj.id);
}

// if element in this.buttons represents a loadingButton that is no longer in the DOM
// then remove it from this.buttons. Also remove remove it if the button being added already
// exists in this.buttons
self.buttons = self.buttons.filter(obj => {
if (obj.inputId == inputId) {
$(document).off('click', "#" + inputId, obj.click_handler);
};
return loadingIds.includes("sf-loading-button-" + obj.inputId) && (obj.inputId !== inputId);
});

self.buttons.push({inputId: inputId, options: options, click_handler: click_button});
});

// Disable button & change text
$(document).on('click', "#" + inputId, click_button);
};

LoadingButtons.prototype.resetLoading = function (inputId) {
Expand Down