-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2 from mermaid-js/develop
Develop
- Loading branch information
Showing
102 changed files
with
10,363 additions
and
4,998 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
**/*.spec.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
name: Question | ||
about: Get some help from the community. | ||
title: '' | ||
labels: 'Help wanted!, Type: Other' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## Help us help you! | ||
You want an answer. Here are some ways to get it quicker: | ||
* Use a clear and concise title. | ||
* Try to pose a clear and concise question. | ||
* Include as much, or as little, code as necessary. | ||
* Don't be shy to give us some screenshots, if it helps! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
name: Build | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [10.x, 12.x] | ||
steps: | ||
- uses: actions/checkout@v1 | ||
|
||
- name: Setup Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
|
||
- name: Install Yarn | ||
run: npm i yarn --global | ||
|
||
- name: Cache Node Modules | ||
uses: actions/cache@v1 | ||
with: | ||
path: .cache | ||
key: ${{ runner.OS }}-build-${{ hashFiles('**/yarn.lock') }} | ||
|
||
- name: Install Packages | ||
run: | | ||
yarn config set cache-folder $GITHUB_WORKSPACE/.cache/yarn | ||
yarn install --frozen-lockfile | ||
env: | ||
CYPRESS_CACHE_FOLDER: ../../.cache/Cypress | ||
|
||
- name: Run Build | ||
run: yarn build | ||
|
||
- name: Run Unit Tests | ||
run: | | ||
yarn test --coverage | ||
cat ./coverage/lcov.info | ./node_modules/.bin/coveralls | ||
env: | ||
COVERALLS_SERVICE_NAME: ${{ secrets.COVERALLS_SERVICE_NAME }} | ||
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} | ||
|
||
- name: Run E2E Tests | ||
run: yarn e2e | ||
env: | ||
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }} | ||
CYPRESS_CACHE_FOLDER: .cache/Cypress |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: Lock closed issue | ||
|
||
on: | ||
issues: | ||
types: [closed] | ||
|
||
jobs: | ||
triage: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: Dunning-Kruger/lock-issues@v1 | ||
with: | ||
repo-token: "${{ secrets.GITHUB_TOKEN }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: Publish release preview package | ||
|
||
on: | ||
push: | ||
branches: | ||
- 'release/**' | ||
|
||
jobs: | ||
publish: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [10.x] | ||
steps: | ||
- uses: actions/checkout@v1 | ||
- name: Setup Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- name: Install Yarn | ||
run: npm i yarn --global | ||
|
||
- name: Install Json | ||
run: npm i json --global | ||
|
||
- name: Install Packages | ||
run: yarn install | ||
|
||
- name: Publish | ||
run: | | ||
PREVIEW_VERSION=$(git rev-list --count --first-parent HEAD) | ||
VERSION=$(echo ${{github.ref}} | tail -c +20)-preview.$PREVIEW_VERSION | ||
echo $VERSION | ||
npm version --no-git-tag-version --allow-same-version $VERSION | ||
npm set //npm.pkg.github.com/:_authToken ${{ secrets.GITHUB_TOKEN }} | ||
npm set registry https://npm.pkg.github.com/mermaid-js | ||
json -I -f package.json -e 'this.name="@mermaid-js/mermaid"' # Package name needs to be set to a scoped one because GitHub registry requires this | ||
json -I -f package.json -e 'this.repository="git://github.com/mermaid-js/mermaid"' # Repo url needs to have a specific format too | ||
npm publish | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: Unlock reopened issue | ||
|
||
on: | ||
issues: | ||
types: [reopened] | ||
|
||
jobs: | ||
triage: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: Dunning-Kruger/unlock-issues@v1 | ||
with: | ||
repo-token: "${{ secrets.GITHUB_TOKEN }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,10 +2,13 @@ | |
|
||
node_modules/ | ||
coverage/ | ||
.idea/ | ||
|
||
dist/*.js | ||
dist/*.map | ||
|
||
yarn-error.log | ||
.npmrc | ||
token | ||
|
||
package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
# Contributing | ||
|
||
So you want to help? That's great! | ||
|
||
![Image of happy people jumping with excitement](https://media.giphy.com/media/BlVnrxJgTGsUw/giphy.gif) | ||
|
||
Here are a few things to know to get you started on the right path. | ||
|
||
## Committing code | ||
|
||
We make all changes via pull requests. As we have many pull requests from developers new to mermaid, the current approach is to have *knsv, Knut Sveidqvist* as a main reviewer of changes and merging pull requests. More precisely like this: | ||
|
||
* Large changes reviewed by knsv or other developer asked to review by knsv | ||
* Smaller low-risk changes like dependecies, documentation etc can be merged by active collaborators | ||
* documentation (updates to the docs folder is also allowed via direct commits) | ||
|
||
To commit code, create a branch, let it start with the type like feature or bug followed by the issue number for reference and some describing text. | ||
|
||
One example: | ||
|
||
`feature/945_state_diagrams` | ||
|
||
Another: | ||
|
||
`bug/123_nasty_bug_branch` | ||
|
||
## Committing documentation | ||
|
||
Less strict here, it is ok to commit directly in the develop branch if you are a collaborator. | ||
|
||
## Branching | ||
|
||
Going forward we will use a git flow inspired approach to branching. So development is done in develop, to do the development in the develop. | ||
|
||
Once development is done we branch a release branch from develop for testing. | ||
|
||
Once the release happens we merge the release branch to master and kill the release branch. | ||
|
||
This means... **branch off your pull request from develop** | ||
|
||
## Content of a pull request | ||
|
||
A new feature has been born. Great! But without the steps below it might just ... fade away ... | ||
|
||
### **Add unit tests for the parsing part** | ||
|
||
This is important so that, if someone else does a change to the grammar that does not know about this great feature, gets notified early on when that change breaks the parser. Another important aspect is that without proper parsing tests refactoring is pretty much impossible. | ||
|
||
### **Add e2e tests** | ||
|
||
This tests the rendering and visual apearance of the diagram. This ensures that the rendering of that feature in the e2e will be reviewed in the release process going forward. Less chance that it breaks! | ||
|
||
To start working with the e2e tests, run `yarn dev` to start the dev server, after that start cypress by running `cypress open` in the mermaid folder. (Make sure you have path to cypress in order, the binary is located in node_modules/.bin). | ||
|
||
The rendering tests are very straightforward to create. There is a function imgSnapshotTest. This function takes a diagram in text form, the mermaid options and renders that diagram in cypress. | ||
|
||
When running in ci it will take a snapshot of the rendered diagram and compare it with the snapshot from last build and flag for review it if it differs. | ||
|
||
This is what a rendering test looks like: | ||
``` | ||
it('should render forks and joins', () => { | ||
imgSnapshotTest( | ||
` | ||
stateDiagram | ||
state fork_state <<fork>> | ||
[*] --> fork_state | ||
fork_state --> State2 | ||
fork_state --> State3 | ||
state join_state <<join>> | ||
State2 --> join_state | ||
State3 --> join_state | ||
join_state --> State4 | ||
State4 --> [*] | ||
`, | ||
{ logLevel: 0 } | ||
); | ||
cy.get('svg'); | ||
}); | ||
``` | ||
|
||
|
||
### **Add documentation for it** | ||
|
||
Finally, if it is not in the documentation, no one will know about it and then **no one will use it**. Wouldn't that be sad? With all the effort that was put into the feature? | ||
|
||
The docs are located in the docs folder and are ofc written in markdown. Just pick the right section and start typing. If you want to add to the structure as in adding a new section and new file you do that via the _navbar.md. | ||
|
||
The changes in master is reflected in http://mermaid-js.github.io/mermaid/ once released the updates are commited to https://mermaid-js.github.io/#/ | ||
|
||
## Last words | ||
|
||
Don't get daunted if it is hard in the beginning. We have a great community with only encouraging words. So if you get stuck, ask for help and hints in the slack forum. If you want to show off something good, show it off there. | ||
|
||
[Join our slack community if you want closer contact!](https://join.slack.com/t/mermaid-talk/shared_invite/enQtNzc4NDIyNzk4OTAyLWVhYjQxOTI2OTg4YmE1ZmJkY2Y4MTU3ODliYmIwOTY3NDJlYjA0YjIyZTdkMDMyZTUwOGI0NjEzYmEwODcwOTE) | ||
|
||
|
||
![Image of superhero wishing you good luck](https://media.giphy.com/media/l49JHz7kJvl6MCj3G/giphy.gif) |
Oops, something went wrong.