Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font awesome not working anymore in link texts #1724

Closed
giovdi opened this issue Oct 9, 2020 · 1 comment · Fixed by #1731
Closed

Font awesome not working anymore in link texts #1724

giovdi opened this issue Oct 9, 2020 · 1 comment · Fixed by #1731
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@giovdi
Copy link

giovdi commented Oct 9, 2020

Describe the bug
Font awesome glyphs are not shown anymore in link texts

I'm using the min.js script and the current config is:

<script src="https://cdn.jsdelivr.net/npm/mermaid/dist/mermaid.min.js"></script>
<script>
	var config = {
		startOnLoad: true,
		flowchart: {
			diagramPadding: 0,
		},
	};
	mermaid.initialize(config);
</script>

but the issue seems not related to a specific platform.

To Reproduce
Use the following schema in the live editor:

graph LR
  A-->|"fa:fa-envelope"| B

Live editor: link

Expected behavior
The envelope icon in the link

Desktop

  • OS: Win10
  • Browser: Chrome
  • Version: 85.0.4183.121

Additional context
Related bug #546

@giovdi giovdi added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 9, 2020
@knsv
Copy link
Collaborator

knsv commented Oct 15, 2020

Very odd, I cant find any traces of this for edge labels, only for vertices. I have added it (again?) for labels.

In flowchart it works already though.

flowchart LR
  A-->|"fa:fa-envelope"| B

After next release it will be available in graph also.

(Also adding a rendering test for this so that if it breaks in the future, it will be noticed...)

knsv added a commit that referenced this issue Oct 15, 2020
knsv added a commit that referenced this issue Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants