Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mermaid does not work in Chrome 48 #281

Closed
kohenkatz opened this issue Jan 21, 2016 · 4 comments
Closed

Mermaid does not work in Chrome 48 #281

kohenkatz opened this issue Jan 21, 2016 · 4 comments

Comments

@kohenkatz
Copy link

In Chrome 48, I get the following error when building Mermaid diagrams:

Uncaught TypeError: elem.getTransformToElement is not a function

Here are the discussion and Chrome Change Report.

This appears to come from the dagre-d3 dependency - see their issue.

It doesn't seem that dagre-d3 has released a fix yet, but I just wanted to open this so that Mermaid updates to the new dagre-js ASAP.

Thanks!
@knsv
Copy link
Collaborator

knsv commented Jan 22, 2016

OK, thanks!

@FranPregernik
Copy link

I got bitten by this today :(

Seems dagre fixed their issue in https://github.com/aequologica/dagr/commit/9b9b050aac02a1440be17cf009dff1afcfeff824

@knsv
Copy link
Collaborator

knsv commented Jan 25, 2016

Me to. Adding a polyfill...

knsv pushed a commit that referenced this issue Jan 25, 2016
Fix for issue #281, support for Chrome v 48
f005c72
FuDesign2008 added a commit to FuDesign2008/MarkdownViewer.vim that referenced this issue Feb 1, 2016
@FuDesign2008
MOD: upadte mermaid to fix mermaid-js/mermaid#281
94809e0
@FuDesign2008 FuDesign2008 mentioned this issue Feb 1, 2016
Closed
@wsw70 wsw70 mentioned this issue Feb 2, 2016
Closed
@vnijs vnijs mentioned this issue Feb 4, 2016
Merged
@cooljig89 cooljig89 mentioned this issue Feb 11, 2016
Closed
@hartzell hartzell mentioned this issue Mar 12, 2016
Closed
@tylerlong
Copy link
Collaborator

Let's close it since Chrome 48 is pretty old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kohenkatz @tylerlong @FranPregernik @knsv