Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C4 examples highlight is unreadable #4905

Closed
italomaia-bk opened this issue Oct 4, 2023 · 1 comment · Fixed by #4924
Closed

C4 examples highlight is unreadable #4905

italomaia-bk opened this issue Oct 4, 2023 · 1 comment · Fixed by #4924
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@italomaia-bk
Copy link

Description

C4 examples use a highlight schema which leaves the text and background in tones in gray and that makes reading them very hard.

Steps to reproduce

  1. go to https://mermaid.js.org/syntax/c4.html#c4-container-diagram-c4container
  2. check any of the examples

Screenshots

no-contrast

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

  • either change highlight so text uses regular "black" color
  • or add support for C4 highlight so proper constrast is used

Additional Context

No response
@italomaia-bk italomaia-bk added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 4, 2023
@raiman264 raiman264 mentioned this issue Oct 7, 2023
Merged
4 tasks
@huynhicode huynhicode mentioned this issue Nov 7, 2023
Closed
4 tasks
sidharthv96 added a commit that referenced this issue Nov 9, 2023
@sidharthv96
Merge pull request #4924 from raiman264/bug/4905_fix_code_block_unrea…
4286372 
…dable_text

bug: #4905 change shiki theme to github-light
@jgreywolf jgreywolf added include roadmap items to add to roadmap for auto workflow and removed include roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
@huynhicode
Copy link
Member

@italomaia-bk Thanks for reporting!

This issue has been fixed in PR-4924.

Screenshot 2023-11-16 at 11 01 32 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: #4905 change shiki theme to github-light raiman264/mermaid
3 participants
@jgreywolf @huynhicode @italomaia-bk