Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 Tests failed because the test timeout is 5 seconds #5053

Closed
omer-priel opened this issue Nov 21, 2023 · 0 comments · Fixed by #5055
Closed

4 Tests failed because the test timeout is 5 seconds #5053

omer-priel opened this issue Nov 21, 2023 · 0 comments · Fixed by #5055
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@omer-priel
Copy link
Contributor

Description

4 Tests faild because the test timeout is 5 seconds.

Faild after and before the first 'pnpm dev':
src/mermaid.spec.ts > when using mermaid and > when using #registerExternalDiagrams > should throw error (but still render) if registerExternalDiagrams fails
src/mermaid.spec.ts > when using mermaid and > when using #registerExternalDiagrams > should defer diagram load based on parameter
Faild only after the first 'pnpm dev':
src/mermaidAPI.spec.ts > mermaidAPI > parse > does not throw for a valid definition
src/mermaidAPI.spec.ts > mermaidAPI > parse > resolves for valid definition

Steps to reproduce

Run the following commands run (2 tests will fail):

pnpm test

For the full commands run (4 tests will fail):

git clone [email protected]:mermaid-js/mermaid.git
cd mermaid
npx pnpm install
pnpm test

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version: develop
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

Change testTimeout in vite.config.ts to 10 seconds. the default value was 5 seconds.
The tests will pass in 7.8 seconds too.

Additional Context

No response

@omer-priel omer-priel added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 21, 2023
@omer-priel omer-priel changed the title 4 Tests faild because the test timeout is 5 seconds 4 Tests failed because the test timeout is 5 seconds Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant