-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add edgeLabelTextColor that take the color from secondaryTextColor #5057
add edgeLabelTextColor that take the color from secondaryTextColor #5057
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I don't know if this bug need new tests? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5057 +/- ##
============================================
- Coverage 79.54% 43.18% -36.37%
============================================
Files 175 23 -152
Lines 14396 5046 -9350
Branches 855 23 -832
============================================
- Hits 11451 2179 -9272
- Misses 2751 2866 +115
+ Partials 194 1 -193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hi @omer-priel, |
@sidharthv96 An example of code from the issue of the bug: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why not all the lines were marked as covered by tests. Maybe they are not. PR looks good. Uniform and simple
📑 Summary
Fixed the bug in #5052 . see in Design Decisions
Resolves #5052
📏 Design Decisions
For edge labels was only the field edgeLabelBackground in styles for color of the background.
I add new field called edgeLabelTextColor (edgeLabel like edgeLabelBackground and TextColor like textColor, nodeTextColor and secondaryTextColor) that take the value from secondaryTextColor
After that I used this field in the FlowChartStyleOptions and getStyles for add "color" and "fill" to edge labels
This solution fix for flowchart and for flowchart/elk and it can work for the other diagrams that has this bug with edge labels. But, I fixed only flowchart for the simplicity of this PR
I dont know if this bug need new tests?
Note: The tests is passing if you chanage the testTimeout. But thay are fiailing now beacuse of #5053
Sory of my english :)
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch