Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencediagram text with <br /> BR tag with space fails #702

Closed
gene1wood opened this issue Jul 24, 2018 · 7 comments · Fixed by #1153
Closed

Sequencediagram text with <br /> BR tag with space fails #702

gene1wood opened this issue Jul 24, 2018 · 7 comments · Fixed by #1153
Assignees
@GDFaber
Labels
Area: Development Graph: Sequence Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@gene1wood
Copy link
Contributor

This works

working example

sequenceDiagram
    participant Joe
    participant Alice
    Joe->>Alice: Foo
    Note over Alice: Bar<br/>Baz
    Note over Joe,Alice: That note above should have had a carriage return between Bar and Baz

but this, with a space between the r and / fails by rendering the <br /> as text not as a line break. One tricky thing is that if you look at it in the interactive view, and then type something on the line with the <br /> it displays correctly, but the view link continues to display incorrectly.

non working example

sequenceDiagram
    participant Joe
    participant Alice
    Joe->>Alice: Foo
    Note over Alice: Bar<br />Baz
    Note over Joe,Alice: That note above should have had a carriage return between Bar and Baz

This may relate to some challenges people had in #384
@gene1wood gene1wood mentioned this issue Jul 24, 2018
Open
@gene1wood gene1wood changed the title Sequencediagram text with BR tag with space fails Sequencediagram text with BR tag with space <br /> fails Jul 24, 2018
@gene1wood gene1wood changed the title Sequencediagram text with BR tag with space <br /> fails Sequencediagram text with <br /> BR tag with space fails Jul 24, 2018
@gene1wood gene1wood mentioned this issue Jul 25, 2018
Closed
watsoncj added a commit to watsoncj/mermaid that referenced this issue Nov 26, 2018
@watsoncj
Support Multi-line Actor Descriptions
2fc5745 
- Add support for <br/> delimiter in actor descriptions.
- Add actorFontFamily and actorFontSize options to sequence diagram.
- Change default actor description font from times to sans.

Fix mermaid-js#384 mermaid-js#702 mermaid-js#755
@watsoncj watsoncj mentioned this issue Nov 26, 2018
Merged
@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Type: New Shape Request for new shape label Jun 29, 2019
@gene1wood
Copy link
Contributor Author

gene1wood commented Jun 29, 2019 •
edited
Loading

@watsoncj You'd said that PR #764 fixes this bug, but when I go and test the non working example above, it still manifests this bug.

@tylerlong merged your PR into 7.0.2 but the bug persists in the current version of 8.1.0.

@stale stale bot removed the Type: New Shape Request for new shape label Jun 29, 2019
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you are still interested in it, and it is still relevant, you can comment or remove the label to revive it.

@github-actions github-actions bot added the Type: New Shape Request for new shape label Sep 24, 2019
@gene1wood
Copy link
Contributor Author

@watsoncj You'd said that PR #764 fixes this bug, but when I go and test the non working example above, it still manifests this bug.

@tylerlong merged your PR into 7.0.2 but the bug persists in the current version of 8.3.0.

@gene1wood
Copy link
Contributor Author

@knsv Could you remove the stale / Status: Wontfix label that the @github-actions bot applied as this issue is still outstanding and waiting on a reply from @watsoncj or a fix?

@IOrlandoni IOrlandoni added Type: Bug / Error Something isn't working or is incorrect Retained Nonperishable Status: Approved Is ready to be worked on Graph: Sequence Contributor needed Area: Development and removed Type: New Shape Request for new shape labels Sep 24, 2019
@GDFaber
Copy link
Member

GDFaber commented Dec 14, 2019 •
edited
Loading

This seems to be similar to #1088. Looking at the commit mentioned above, the regex <br\/?> is used to determine the lines. This takes care of <br> and <br/> but does not find <br />.

If noone else is already working on this issue, I can take a look at it.

@GDFaber GDFaber mentioned this issue Dec 14, 2019
Closed
@GDFaber
Copy link
Member

GDFaber commented Dec 19, 2019

PR coming up for the weekend I suppose.

@GDFaber GDFaber mentioned this issue Dec 21, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GDFaber GDFaber

Labels
Area: Development Graph: Sequence Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/702 br tags in sequence diagrams GDFaber/mermaid
4 participants
@gene1wood @IOrlandoni @GDFaber @klemmchr