Prevent un-labelled edges that are left of the left-most vertex from …

[spopida]

…being cut off the diagram

📑 Summary

Fix viewBox mapping to svg viewport to prevent left-most edges being sliced off in some cases

Resolves #1327

📏 Design Decisions

A change to the way the viewBox is defined in flowRenderer.js. It now uses svgBounds.x and svgBounds.y to determine its minimum x and y values respectively (with an adjustment for padding around the diagram). This is instead of using (0,0), because it is possible for unlabelled edges to have negative co-ordinates which meant that they got 'sliced' off. The viewBox now correctly maps onto the svg viewport even if the latter has negative minima.

Also, a new integration test has been added to include an example equivalent to that provided by the bug reporter so that this case is included in regression tests.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 🔖 targeted develop branch

[jgreywolf]

Minor comment - this same thing needs to be done for ClassDiagrams as well. I wont be able to do anything here until late next week, so if you feel ambitious.. :)

[spopida]

@jgreywolf - I'll try to take a look in the next couple of days... :-)

[GDFaber]

Awesome, thanks for fixing this.