Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flowchart subroutine node shape #1345

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Add flowchart subroutine node shape #1345

merged 2 commits into from
Apr 11, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Apr 9, 2020

📑 Summary

Adds a new node shape to flowcharts which represents a subroutine.

Resolves #1343

📏 Design Decisions

Added polygon shape to flowchart shapes. Extended unit tests as well as the flowchart documentation on node shapes.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit 6ec731e into mermaid-js:develop Apr 11, 2020
@jrdavismaine
Copy link
Contributor

Thank you @GDFaber and @knsv for implementing so quickly! Cheers

@GDFaber GDFaber deleted the feature/1343_add_flowchart_subroutine_shape branch April 11, 2020 20:22
@jrdavismaine jrdavismaine mentioned this pull request May 7, 2020
Closed
3 tasks
@jrdavismaine
Copy link
Contributor

Looks perfect. Thanks again @GDFaber and @knsv
image

@jgreywolf jgreywolf mentioned this pull request Jan 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subroutine flow chart symbol question
3 participants
@GDFaber @jrdavismaine @knsv