Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of sanitize-url #2790

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Update to latest version of sanitize-url #2790

merged 1 commit into from
Mar 3, 2022

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Mar 3, 2022

📑 Summary

There's been a bunch of fixes and a security issue resolved in the latest version. See also https://github.com/braintree/sanitize-url/blob/main/CHANGELOG.md#600

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@dbussink
Copy link
Contributor Author

dbussink commented Mar 3, 2022

The docs not being in sync also seems to happen on develop and isn't related to the changes in this PR.

There's been a bunch of security issues in the older versions of sanitize-url that this resolves.
@dbussink
Copy link
Contributor Author

dbussink commented Mar 3, 2022

Upstream sanitize-url behavior has changed since 4.0 as mentioned in https://github.com/braintree/sanitize-url/blob/main/CHANGELOG.md#400 to allow protocol-less URLs. I've updated the tests here accordingly.

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants