Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XYChart's nav link in the docs template #5014

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update XYChart's nav link in the docs template #5014

merged 1 commit into from
Nov 8, 2023

Conversation

Abrifq
Copy link
Contributor

@Abrifq Abrifq commented Nov 5, 2023

📑 Summary

Brief description about the content of your PR.

The site gives 404 with xychart but navigates correctly with xyChart

Resolves #4984

📏 Design Decisions

N/A

📋 Tasks

Make sure you

The site gives 404 with xychart but navigates correctly with xyChart
Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b61ea4b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6547eec0bf099b00089bcb5c
😎 Deploy Preview https://deploy-preview-5014--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #5014 (b61ea4b) into develop (f5bd1e0) will increase coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5014      +/-   ##
===========================================
+ Coverage    79.37%   79.64%   +0.27%     
===========================================
  Files          164      164              
  Lines        13820    13820              
  Branches       693      693              
===========================================
+ Hits         10969    11007      +38     
+ Misses        2702     2664      -38     
  Partials       149      149              
Flag Coverage Δ
e2e 85.57% <ø> (+0.35%) ⬆️
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

We do have a Link Checker GitHub Action that normally checks to see if all our links are working, but it currently only checks Markdown files. Maybe it's worth us running it on the built-website too so it checks links in the template too.

@aloisklink aloisklink added this pull request to the merge queue Nov 8, 2023
Merged via the queue into mermaid-js:develop with commit 71478f5 Nov 8, 2023
18 checks passed
Copy link

mermaid-bot bot commented Nov 8, 2023

@Abrifq, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@Abrifq
Copy link
Contributor Author

Abrifq commented Nov 8, 2023

I'm glad to help!

By the way, do you know anyone that can review/merge mermaid-js/mermaid-live-editor#1335

@aloisklink
Copy link
Member

By the way, do you know anyone that can review/merge mermaid-js/mermaid-live-editor#1335

Hmmmm, I'm not too familiar with Svelte or the mermaid-live-editor project, but if it's only a documentation change and it still hasn't been reviewed, I can try having a look at this weekend. It looks like I also have merge permissions for that repo, so assuming everything is fine, I can even merge it!

I think the mermaid-live-editor project only has a single maintainer currently, so PRs there might be a bit slower to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - Syntax - XYChart 404 Page not found
3 participants