Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: render the participants in same order as they are created" #5198

Merged

Conversation

sidharthv96
Copy link
Member

Reverts #5017

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 11542b3
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65a4e433b418760008b5eb36
😎 Deploy Preview https://deploy-preview-5198--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jan 15, 2024
@sidharthv96 sidharthv96 added this pull request to the merge queue Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c43e8e) 80.12% compared to head (11542b3) 77.99%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5198      +/-   ##
===========================================
- Coverage    80.12%   77.99%   -2.14%     
===========================================
  Files          167      167              
  Lines        13873    13873              
  Branches       707      707              
===========================================
- Hits         11116    10820     -296     
- Misses        2603     2893     +290     
- Partials       154      160       +6     
Flag Coverage Δ
e2e 83.43% <100.00%> (-2.69%) ⬇️
unit 43.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 79.91% <100.00%> (-9.33%) ⬇️
packages/mermaid/src/diagrams/sequence/svgDraw.js 84.04% <100.00%> (-4.26%) ⬇️

... and 15 files with indirect coverage changes

Merged via the queue into develop with commit 7508d9a Jan 15, 2024
26 checks passed
@sidharthv96 sidharthv96 deleted the revert-5017-bug/4946-fix-svg-order-sequence-participant branch January 15, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant