Update contribute #5268
Merged
Update contribute #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sidharthv96
requested changes
Feb 6, 2024
Comment on lines
42
to
43
| [Join our slack community if you want closer contact!](https://join.slack.com/t/mermaid-talk/shared_invite/enQtNzc4NDIyNzk4OTAyLWVhYjQxOTI2OTg4YmE1ZmJkY2Y4MTU3ODliYmIwOTY3NDJlYjA0YjIyZTdkMDMyZTUwOGI0NjEzYmEwODcwOTE) | ||
|
|
||
| [You can also join our Discord server!](https://discord.gg/vVDmXwhpaS) | ||
|
|
There was a problem hiding this comment.
We should remove the slack link.
There was a problem hiding this comment.
Please update the Discord invite link to:
huynhicode
requested changes
Feb 6, 2024
Comment on lines
42
to
43
| [Join our slack community if you want closer contact!](https://join.slack.com/t/mermaid-talk/shared_invite/enQtNzc4NDIyNzk4OTAyLWVhYjQxOTI2OTg4YmE1ZmJkY2Y4MTU3ODliYmIwOTY3NDJlYjA0YjIyZTdkMDMyZTUwOGI0NjEzYmEwODcwOTE) | ||
|
|
||
| [You can also join our Discord server!](https://discord.gg/vVDmXwhpaS) | ||
|
|
There was a problem hiding this comment.
Please update the Discord invite link to:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5268 +/- ##
============================================
- Coverage 80.08% 43.22% -36.87%
============================================
Files 167 23 -144
Lines 13867 5037 -8830
Branches 741 23 -718
============================================
- Hits 11106 2177 -8929
- Misses 2594 2859 +265
+ Partials 167 1 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1. Added a link to the Discord server
1. Removed the Slack invite and left only the Discord invite
1. Removed the Slack link 2. Updated the Discord invite link
sidharthv96
force-pushed
the
updateContribute
branch
from
56999f4
to
ec7591b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
I added a Discord invite link to the
intro.htmlfile so that new contributors can quickly join the Mermaid DIscord server and chat with other members of the community.This doesn't resolve any issue in the issue tracker. I had previously closed this issue because I thought PR #5225 addressed this page on the Mermaid website.
📏 Design Decisions
I simply created an invite link that didn't expire and added it to the page.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch