Replace version number placeholder #5304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header of the section contains the version number for the feature, so the warning box should contain the same version
📑 Summary
In own section of the documentation the
MERMAID_RELEASE_VERSION
was used literally at one place. May it was an misunderstand or a slip in 4efac67.📏 Design Decisions
The
MERMAID_RELEASE_VERSION
is not suitable here. If I understand correctly a<MERMAID_RELEASE_VERSION>
in the markdown would be replaced with the current version of mermaid (e.g., in the Contributing page), but a specific feature is introduced in a specific version. So a dynamic version number is not suitable here.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch