Fix chrome webstore url causing 404 #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now it's "Too many redirects" like all of it's brethren 🙂
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5352 +/- ##
============================================
+ Coverage 43.37% 79.22% +35.85%
============================================
Files 23 175 +152
Lines 5130 14531 +9401
Branches 23 868 +845
============================================
+ Hits 2225 11512 +9287
+ Misses 2904 2816 -88
- Partials 1 203 +202
Flags with carried forward coverage won't be shown. Click here to find out more. |
Wait, it complained about a table in markdown? Why??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now it's "Too many redirects" like all of it's brethren 🙂
I should open a issue on lychee for this problem but also it's not their fault
idk, it's annoying, it's noise.
How do you guys filter it?
📑 Summary
Fixing one link that had a slash at the end of it. Turns out new chrome webstore doesn't like that!
Resolves my pet peeves, for now.
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch