Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix node version in CONTRIBUTING.md #5573

Merged

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jun 15, 2024

📑 Summary

Resolves #5572

📏 Design Decisions

N/A

📋 Tasks

Make sure you

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 9c3bcec
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66731dc1d09717000890a47e
😎 Deploy Preview https://deploy-preview-5573--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (63f9e95) to head (9c3bcec).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5573   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          277     277           
  Lines        41988   41988           
  Branches       515     515           
=======================================
  Hits          2409    2409           
  Misses       39579   39579           
Flag Coverage Δ
unit 5.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nirname
Copy link
Contributor

nirname commented Jun 19, 2024

Thank you for the contribution. I know it is a bit confusing, but no need for updating docs folder manually (only those which are inside the package).

@nirname nirname enabled auto-merge June 19, 2024 18:23
@nirname nirname added this pull request to the merge queue Jun 19, 2024
Merged via the queue into mermaid-js:develop with commit 0044aa3 Jun 19, 2024
19 checks passed
Copy link

mermaid-bot bot commented Jun 19, 2024

@exoego, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@exoego exoego deleted the docs/5572_node-version-contributing-md branch June 19, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node version in CONTRIBUTING.md mismatches with .node-version
2 participants