Skip to content

Commit

Permalink
TestServiceDependenciesListensFromSamePort test added for service pac…
Browse files Browse the repository at this point in the history
…kage, related with #380, #371 (#381)
  • Loading branch information
ilgooz authored and NicolasMahe committed Aug 22, 2018
1 parent 3ecfa9a commit 2dd2652
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion service/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func (service *Service) Start() (serviceIDs []string, err error) {
}(dependency, i)
}
wg.Wait()
// Grasfully stop the service because there is an error
// Gracefully stop the service because there is an error
if err != nil {
service.Stop()
}
Expand Down
31 changes: 31 additions & 0 deletions service/status_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,34 @@ func TestListMultipleDependencies(t *testing.T) {
require.Equal(t, len(list), 1)
require.Equal(t, list[0], hash)
}

func TestServiceDependenciesListensFromSamePort(t *testing.T) {
var (
service = &Service{
Name: "TestServiceDependenciesListensFromSamePort",
Dependencies: map[string]*Dependency{
"test": {
Image: "nginx",
Ports: []string{"80"},
},
},
}

service1 = &Service{
Name: "TestServiceDependenciesListensFromSamePort1",
Dependencies: map[string]*Dependency{
"test": {
Image: "nginx",
Ports: []string{"80"},
},
},
}
)
_, err := service.Start()
require.NoError(t, err)
defer service.Stop()

_, err = service1.Start()
require.NotZero(t, err)
require.Contains(t, err.Error(), `port '80' is already in use`)
}

0 comments on commit 2dd2652

Please sign in to comment.