Skip to content

Commit

Permalink
remove useless tests
Browse files Browse the repository at this point in the history
  • Loading branch information
antho1404 committed Jun 24, 2019
1 parent b11a3d5 commit 4abd07a
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 419 deletions.
55 changes: 0 additions & 55 deletions sdk/sdk_test.go

This file was deleted.

117 changes: 0 additions & 117 deletions server/grpc/core/core_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,126 +8,9 @@ import (

"github.com/mesg-foundation/core/config"
"github.com/mesg-foundation/core/protobuf/coreapi"
executionsdk "github.com/mesg-foundation/core/sdk/execution"
"github.com/mesg-foundation/core/service"
"github.com/stretchr/testify/require"
)

func TestExecute(t *testing.T) {
var (
taskKey = "call"
data = `{"url": "https://mesg.com", "data": {}, "headers": {}}`
server, closer = newServer(t)
)
defer closer()

s, validationErr, err := server.sdk.DeployService(serviceTar(t, taskServicePath), nil)
require.Zero(t, validationErr)
require.NoError(t, err)
defer server.sdk.DeleteService(s.Hash, false)

require.NoError(t, server.sdk.StartService(s.Hash))
defer server.sdk.StopService(s.Hash)

reply, err := server.ExecuteTask(context.Background(), &coreapi.ExecuteTaskRequest{
ServiceID: s.Hash.String(),
TaskKey: taskKey,
InputData: data,
})
require.NoError(t, err)
require.NotEqual(t, "", reply.ExecutionHash)
}

func TestExecuteWithInvalidJSON(t *testing.T) {
server, closer := newServer(t)
defer closer()

s, validationErr, err := server.sdk.DeployService(serviceTar(t, taskServicePath), nil)
require.Zero(t, validationErr)
require.NoError(t, err)
defer server.sdk.DeleteService(s.Hash, false)

_, err = server.ExecuteTask(context.Background(), &coreapi.ExecuteTaskRequest{
ServiceID: s.Hash.String(),
TaskKey: "test",
InputData: "",
})
require.Error(t, err)
require.Equal(t, err.Error(), "cannot parse execution's inputs (JSON format): unexpected end of JSON input")
}

func TestExecuteWithInvalidTask(t *testing.T) {
var (
taskKey = "error"
server, closer = newServer(t)
)
defer closer()

s, validationErr, err := server.sdk.DeployService(serviceTar(t, taskServicePath), nil)
require.Zero(t, validationErr)
require.NoError(t, err)
defer server.sdk.DeleteService(s.Hash, false)

require.NoError(t, server.sdk.StartService(s.Hash))
defer server.sdk.StopService(s.Hash)

_, err = server.ExecuteTask(context.Background(), &coreapi.ExecuteTaskRequest{
ServiceID: s.Hash.String(),
TaskKey: taskKey,
InputData: "{}",
})
require.Error(t, err)
notFoundErr, ok := err.(*service.TaskNotFoundError)
require.True(t, ok)
require.Equal(t, taskKey, notFoundErr.TaskKey)
require.Equal(t, s.Name, notFoundErr.ServiceName)
}

func TestExecuteWithInvalidTaskInput(t *testing.T) {
var (
taskKey = "call"
data = `{"headers": {}}`
server, closer = newServer(t)
)
defer closer()

s, validationErr, err := server.sdk.DeployService(serviceTar(t, taskServicePath), nil)
require.Zero(t, validationErr)
require.NoError(t, err)
defer server.sdk.DeleteService(s.Hash, false)

require.NoError(t, server.sdk.StartService(s.Hash))
defer server.sdk.StopService(s.Hash)

_, err = server.ExecuteTask(context.Background(), &coreapi.ExecuteTaskRequest{
ServiceID: s.Hash.String(),
TaskKey: taskKey,
InputData: data,
})
require.Error(t, err)
invalidErr, ok := err.(*service.InvalidTaskInputError)
require.True(t, ok)
require.Equal(t, taskKey, invalidErr.TaskKey)
require.Equal(t, s.Name, invalidErr.ServiceName)
}

func TestExecuteWithNonRunningService(t *testing.T) {
server, closer := newServer(t)
defer closer()

s, validationErr, err := server.sdk.DeployService(serviceTar(t, taskServicePath), nil)
require.Zero(t, validationErr)
require.NoError(t, err)
defer server.sdk.DeleteService(s.Hash, false)

_, err = server.ExecuteTask(context.Background(), &coreapi.ExecuteTaskRequest{
ServiceID: s.Hash.String(),
TaskKey: "test",
InputData: "{}",
})
require.Equal(t, &executionsdk.NotRunningServiceError{ServiceID: s.Hash.String()}, err)
}

func TestExecuteWithNonExistingService(t *testing.T) {
server, closer := newServer(t)
defer closer()
Expand Down
15 changes: 0 additions & 15 deletions server/grpc/core/test_test.go
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
package core

import (
"io"
"os"
"path/filepath"
"testing"

"github.com/docker/docker/pkg/archive"
"github.com/mesg-foundation/core/container"
"github.com/mesg-foundation/core/database"
"github.com/mesg-foundation/core/sdk"
"github.com/stretchr/testify/require"
)

var (
taskServicePath = filepath.Join("..", "..", "..", "service-test", "task")
)

const (
servicedbname = "service.db.test"
instancedbname = "instance.db.test"
Expand Down Expand Up @@ -52,11 +45,3 @@ func newServer(t *testing.T) (*Server, func()) {
require.NoError(t, err)
return newServerWithContainer(t, c)
}

func serviceTar(t *testing.T, path string) io.Reader {
reader, err := archive.TarWithOptions(path, &archive.TarOptions{
Compression: archive.Gzip,
})
require.NoError(t, err)
return reader
}
Loading

0 comments on commit 4abd07a

Please sign in to comment.