-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back validation on service struct #1088
Comments
PR #1099 add the validation function but now a another PR is needed to actually call the validation! |
There is also validation missing:
|
Still missing some validation on Parameter keys: https://github.com/mesg-foundation/engine/pull/1110/files#r297480614 |
@krhubert Please check comment: https://github.com/mesg-foundation/engine/pull/1110/files#r297479535 |
@krhubert please check if can be close |
I've checked and the issue is still unresolved. |
The validation for repeted object keys is imposible because json won't allow us to send the same data multiple time (the cli parse it as error), but I've added validation anyway :) |
We need to add back the validation on the service, this time directly on the service.Service structure instead of the import.Service!
The text was updated successfully, but these errors were encountered: