Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back validation on service struct #1088

Closed
NicolasMahe opened this issue Jun 24, 2019 · 7 comments · Fixed by #1110 or #1451
Closed

Add back validation on service struct #1088

NicolasMahe opened this issue Jun 24, 2019 · 7 comments · Fixed by #1110 or #1451
Assignees
Labels
bug Something isn't working low priority

Comments

@NicolasMahe
Copy link
Member

We need to add back the validation on the service, this time directly on the service.Service structure instead of the import.Service!

@NicolasMahe
Copy link
Member Author

PR #1099 add the validation function but now a another PR is needed to actually call the validation!

@antho1404
Copy link
Member

antho1404 commented Jun 25, 2019

There is also validation missing:

  • ports
  • source
  • "unique" validation for arrays
  • make sure that the validation removed in the array is valid. What's the behavior when we send an array of null for example? We should require the values

@NicolasMahe
Copy link
Member Author

Still missing some validation on Parameter keys: https://github.com/mesg-foundation/engine/pull/1110/files#r297480614

@NicolasMahe
Copy link
Member Author

@NicolasMahe
Copy link
Member Author

@krhubert please check if can be close

@krhubert
Copy link
Contributor

krhubert commented Jul 1, 2019

I've checked and the issue is still unresolved.

@krhubert
Copy link
Contributor

 ›   Error: duplicated mapping key at line 20, column -25:
 ›              res:
 ›              ^

The validation for repeted object keys is imposible because json won't allow us to send the same data multiple time (the cli parse it as error), but I've added validation anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
3 participants