Add more validation to service struct #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
fix/service-validation
branch
from
54d2497
to
7811fce
Compare
antho1404
approved these changes
Jun 26, 2019
Merged
NicolasMahe
reviewed
Jun 26, 2019
| @@ -22,5 +22,5 @@ type Parameter struct { | |||
| Repeated bool `hash:"name:6"` | |||
|
|
|||
| // Definition of the structure of the object when the type is object | |||
| Object []*Parameter `hash:"name:7"` | |||
| Object []*Parameter `hash:"name:7" validate:"unique,dive,required"` | |||
There was a problem hiding this comment.
why this one is unique?
does it actually works?
There was a problem hiding this comment.
it won't be used here, but shouldn't exist
NicolasMahe
reviewed
Jun 26, 2019
|
|
||
| existparam := make(map[string]bool) | ||
| for _, param := range event.Data { | ||
| if existparam[param.Key] { |
There was a problem hiding this comment.
params.Object keys are not tested (task inputs, task outputs and event)
maybe we could use the validation lib with something like:
Object []*Parameter `hash:"name:7" validate:"dive,(key)unique,required"`
otherwise a function that validate keys of type []*Parameter that can be called recursively.
There was a problem hiding this comment.
otherwise a new custom validation like PortMapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1088